Skip to content

VTGate Expression Evaluation #6042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
systay merged 24 commits into from
Apr 17, 2020
Merged

VTGate Expression Evaluation #6042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
40b7423
Added SingleRow Engine Definition
saifalharthi Apr 6, 2020
3464ea6
Added Projection plan and Primitive
saifalharthi Apr 6, 2020
b56994a
Added ability to evaluate numerical and expressions with bind variables
saifalharthi Apr 8, 2020
2f05ccc
Support Expression evalution for BindVariables and literals
saifalharthi Apr 9, 2020
8a546b8
Refactoring of expressions
systay Apr 9, 2020
b4f8ddc
Cleanup of test
systay Apr 9, 2020
8e858ed
Fix up some tests for last_insert_ID, databaste(), and variables
saifalharthi Apr 10, 2020
3f1fe3b
Fixed expression evaluation for Union and virtual tables
saifalharthi Apr 10, 2020
1b692d2
Fix plan tests and modify descriptions
saifalharthi Apr 10, 2020
230e34e
Supported evalution of column types
saifalharthi Apr 11, 2020
2601780
Handle type logic for binary operators
systay Apr 11, 2020
46c228e
Update test assertions
systay Apr 11, 2020
cfcb904
Code clean up
systay Apr 12, 2020
95f7309
Add expression evaluation fallback mechanism
rohit-nayak-ps Apr 14, 2020
085f7ff
Removed unused test
rohit-nayak-ps Apr 14, 2020
09e5e4e
Extract vtgate execution from primitive builder
rohit-nayak-ps Apr 14, 2020
ffddcc5
Support for literal float
rohit-nayak-ps Apr 14, 2020
5efc63a
Compute literal int during plan evaluation
rohit-nayak-ps Apr 14, 2020
f0711f1
Fix SingleRow's select cases test
saifalharthi Apr 14, 2020
c802dcc
Resolve merge conflict
saifalharthi Apr 15, 2020
faae89a
Add StreamExecute for projection and add unreachable comment to arith…
saifalharthi Apr 15, 2020
d391f0a
Move evaluation expression to its own package
saifalharthi Apr 17, 2020
06c21e1
Fix formatter check
saifalharthi Apr 17, 2020
23da224
Fix import
systay Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion go/mysql/endtoend/replication_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import (
"testing"
"time"

"vitess.io/vitess/go/vt/vtgate/evalengine"

"golang.org/x/net/context"

"vitess.io/vitess/go/mysql"
Expand Down Expand Up @@ -68,7 +70,7 @@ func connectForReplication(t *testing.T, rbr bool) (*mysql.Conn, mysql.BinlogFor
t.Fatalf("SHOW MASTER STATUS returned unexpected result: %v", result)
}
file := result.Rows[0][0].ToString()
position, err := sqltypes.ToUint64(result.Rows[0][1])
position, err := evalengine.ToUint64(result.Rows[0][1])
if err != nil {
t.Fatalf("SHOW MASTER STATUS returned invalid position: %v", result.Rows[0][1])
}
Expand Down
Loading