VTGate Expression Evaluation#6042
Merged
systay merged 24 commits intovitessio:masterfrom Apr 17, 2020
Merged
Conversation
Contributor
Author
Collaborator
|
Test failures do not seem to be related |
systay
approved these changes
Apr 10, 2020
Member
|
--- FAIL: TestDatabaseFunc (0.00s) This might be related. |
saifalharthi
changed the title
Contributor
Author
|
Failing test is not related to the chagnes. |
Member
harshit-gangal
left a comment
harshit-gangal
left a comment
There was a problem hiding this comment.
I would suggest to rebase from master as I expect some test to fail with latest master
go/vt/vtgate/engine/projection.go
Outdated
Comment on lines
41
to
54
Member
There was a problem hiding this comment.
Does this need result from input.execute? The results are manipulated here.
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
sa-expression-evalution
branch
from
ec9ae69 to
95f7309
Compare
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Contributor
Author
|
Flaky tests are back |
Contributor
Author
|
It's OK to merge as the failing tests are not related to the changes. |
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
harshit-gangal
approved these changes
Apr 15, 2020
…metic Addition and Subtraction type check Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Saif Alharthi <saif@saifalharthi.me>
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to evaluate expression at the VTGate level. At this point it handles Literals and bind variables.