Vreplication workflow renaming#5968
Merged
sougou merged 6 commits intovitessio:masterfrom Mar 28, 2020
Merged
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
sougou
reviewed
Mar 25, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Can you also rename the migrater type to trafficSwitcher?
streamMigrater can keep its name.
…s missing in test case Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Member
Author
|
Hmm, I see the same error after the last push. Guess there was other similar bugs floating around: back to the drawing board ... |
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…renaming Signed-off-by: Rohit Nayak <rohit@planetscale.com>
sougou
approved these changes
Mar 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Migrate -> MoveTables
MigrateReads -> SwitchReads
MigrateWrites -> SwitchWrites