Updated local example to use new VReplication commands. Moved existin…#5910
Closed
rohit-nayak-ps wants to merge 3 commits intovitessio:masterfrom
Closed
Updated local example to use new VReplication commands. Moved existin…#5910rohit-nayak-ps wants to merge 3 commits intovitessio:masterfrom
rohit-nayak-ps wants to merge 3 commits intovitessio:masterfrom
Conversation
…g to legacy directory/workflow Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Contributor
|
LGTM, as mentioned on Slack just a couple of nits:
|
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
sougou
reviewed
Mar 20, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
This looks good. We should coincide this merge with our documentation.
Also, we should merge this after the PR that has bug fixes and e2e tests.
Closed
deepthi
previously requested changes
Mar 24, 2020
…lly changed files back to 2019 Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Member
Author
|
Note that this depends on #5968 for the tests run since it now uses the renamed commands. |
morgo
reviewed
Mar 26, 2020
deepthi
dismissed
their stale review
Changes have been made, but there are open requests from othe rreviewers
deepthi
reviewed
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g to legacy directory/workflow
Docs PR will be: vitessio/website#415
Signed-off-by: Rohit Nayak rohit@planetscale.com