Skip to content

Xtrabackup endtoend test cases in GO migrated from Python#5743

Merged
deepthi merged 18 commits intovitessio:masterfrom
planetscale:xtrabackup
Jan 29, 2020
Merged

Xtrabackup endtoend test cases in GO migrated from Python#5743
deepthi merged 18 commits intovitessio:masterfrom
planetscale:xtrabackup

Conversation

@ajeetj
Copy link
Copy Markdown
Contributor

@ajeetj ajeetj commented Jan 21, 2020

Please do a squash merge

Restructured the vtctl based backup to call it for xtrabackup.

Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj ajeetj requested a review from sougou as a code owner January 21, 2020 09:41
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase and resolve conflicts.

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jan 22, 2020

This will need to wait until #5693 is merged.

@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jan 29, 2020

Now that #5693 has been merged, can you rebase / merge and resolve the conflicts?

Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
@ajeetj
Copy link
Copy Markdown
Contributor Author

ajeetj commented Jan 29, 2020

Now that #5693 has been merged, can you rebase / merge and resolve the conflicts?

@deepthi Conflict resolved.

Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 041757f into vitessio:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants