Backup using vtbackup endtoend test cases in Go migrated from Python#5693
Backup using vtbackup endtoend test cases in Go migrated from Python#5693deepthi merged 6 commits intovitessio:masterfrom
Conversation
ajeetj
force-pushed
the
tal_backup_only
branch
from
69b3a0e to
975645f
Compare
ajeetj
changed the title
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Mostly looks good.
It will be nice to reuse common code for list/count/remove backups.
Also, the merge conflict needs to be resolved.
There was a problem hiding this comment.
can these local functions be replaced by shared code?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, that was the plan.
But Pradip also started making changes in that common code. And if I update it in my PR then there will be a lot of merge conflicts. We will make sure it is cleaned up in his PR.
There was a problem hiding this comment.
ok I'll approve for now and you can fix this in the other PR.
There was a problem hiding this comment.
If this is no longer relevant, delete instead of commenting out.
There was a problem hiding this comment.
I am not 100% sure.
As we are restarting the mysql here the rest of the code is not at all required. Like promoteSlaveCommands & disableSemiSyncCommands
Ideally, we will have to uncomment the commented code and comment resetTabletDirectory(t, tablet, initMysql). But that doesn't work
There was a problem hiding this comment.
Let's get this merged and investigate that separately.
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: Ajeet jain <ajeet@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
arindamnayak
force-pushed
the
tal_backup_only
branch
from
2ff9d26 to
d284e71
Compare
2 participants
Migrated vtbackup testcases from python to go.