Add vttablet auth support for external Azure MySQL.#5683
Merged
sougou merged 1 commit intovitessio:masterfrom Jan 10, 2020
Merged
Add vttablet auth support for external Azure MySQL.#5683sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
Azure ignores the mysql_native_password in the MySQL Login Request packet, and then issues a Auth Switch Request specifying the mysql_native_password again, and passing a new salt. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
sougou
approved these changes
Jan 10, 2020
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
I would have normally insisted on a test. But, knowing that this is a quirk of how Azure is setup, and that you've tested it manually, we can let this through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure ignores the mysql_native_password in
the MySQL Login Request packet, and then issues
a Auth Switch Request specifying the mysql_native_password
again, and passing a new salt.
Signed-off-by: Jacques Grove aquarapid@gmail.com