server testing with multiple statement, query-timeout and warnings.#5671
server testing with multiple statement, query-timeout and warnings.#5671deepthi merged 1 commit intovitessio:masterfrom princeparmar:mysql-server
Conversation
sougou
left a comment
There was a problem hiding this comment.
I have some mixed feelings about this. So, want to collect feedback from others in the community.
The concern is that we are introducing new dependencies. The fear I have is that this may make the project more fragile.
On the other hand, this test proves that vitess works with other drivers or ORMs, which is a good thing.
I want to see if others have any thoughts about this.
I will chime in with mine. I see this as a choice between stability or compatibility. I prefer compatibility in this specific case. i.e. if vttablet used go-sql-driver/mysql, I don't think we would have had to work on #5683 ; I assume in future we will need to add |
|
Can you rebase or merge and resolve the conflicts? |
Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
|
@deepthi Please use Squash & Merge for this PR. |
Signed-off-by: pradip parmar prince.soamedia@gmail.com