Skip to content

server testing with multiple statement, query-timeout and warnings.#5671

Merged
deepthi merged 1 commit intovitessio:masterfrom
princeparmar:mysql-server
Jan 17, 2020
Merged

server testing with multiple statement, query-timeout and warnings.#5671
deepthi merged 1 commit intovitessio:masterfrom
princeparmar:mysql-server

Conversation

@princeparmar
Copy link
Copy Markdown
Contributor

Signed-off-by: pradip parmar prince.soamedia@gmail.com

@princeparmar princeparmar requested a review from sougou as a code owner January 8, 2020 11:33
Copy link
Copy Markdown
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some mixed feelings about this. So, want to collect feedback from others in the community.

The concern is that we are introducing new dependencies. The fear I have is that this may make the project more fragile.

On the other hand, this test proves that vitess works with other drivers or ORMs, which is a good thing.

I want to see if others have any thoughts about this.

@morgo
Copy link
Copy Markdown
Contributor

morgo commented Jan 13, 2020

The concern is that we are introducing new dependencies. The fear I have is that this may make the project more fragile.

On the other hand, this test proves that vitess works with other drivers or ORMs, which is a good thing.

I want to see if others have any thoughts about this.

I will chime in with mine. I see this as a choice between stability or compatibility. I prefer compatibility in this specific case.

i.e. if vttablet used go-sql-driver/mysql, I don't think we would have had to work on #5683 ; I assume in future we will need to add caching_sha2_password #5399 whereas this is already supported in go-sql-driver/mysql.

@princeparmar princeparmar requested a review from morgo as a code owner January 15, 2020 07:22
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Jan 15, 2020

Can you rebase or merge and resolve the conflicts?

Signed-off-by: pradip parmar <prince.soamedia@gmail.com>
@ajeetj
Copy link
Copy Markdown
Contributor

ajeetj commented Jan 16, 2020

@deepthi Please use Squash & Merge for this PR.

Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 4e46a60 into vitessio:master Jan 17, 2020
@princeparmar princeparmar deleted the mysql-server branch January 20, 2020 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants