Skip to content

vtbackup: Stop replication after reaching goal position. #5437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enisoc merged 1 commit into from
Nov 15, 2019
Merged

vtbackup: Stop replication after reaching goal position. #5437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion go/cmd/vtbackup/vtbackup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,12 +379,17 @@ func takeBackup(ctx context.Context, topoServer *topo.Server, backupStorage back
}
}

// Stop replication and see where we are.
if err := mysqld.StopSlave(nil); err != nil {
return fmt.Errorf("can't stop replication: %v", err)
}

// Did we make any progress?
status, err := mysqld.SlaveStatus()
if err != nil {
return fmt.Errorf("can't get replication status: %v", err)
}
log.Infof("Replication caught up to at least %v", status.Position)
log.Infof("Replication caught up to %v", status.Position)
if !status.Position.AtLeast(masterPos) && status.Position.Equal(restorePos) {
return fmt.Errorf("not taking backup: replication did not make any progress from restore point: %v", restorePos)
}
Expand Down