vtbackup: Stop replication after reaching goal position.#5437
Merged
enisoc merged 1 commit intovitessio:masterfrom Nov 15, 2019
Merged
vtbackup: Stop replication after reaching goal position.#5437enisoc merged 1 commit intovitessio:masterfrom
enisoc merged 1 commit intovitessio:masterfrom
Conversation
In xtrabackup mode, we would normally leave replication running when taking a backup on a tablet. However, since this is not a serving tablet, we stop replication in advance to help make xtrabackup's job easier. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In xtrabackup mode, we would normally leave replication running when taking a backup on a tablet. However, since this is not a serving tablet, we stop replication in advance to help make xtrabackup's job
easier. In particular, we've observed that this seems to make it less likely that xtrabackup gets stuck during
Executing FLUSH TABLES WITH READ LOCK.Signed-off-by: Anthony Yeh enisoc@planetscale.com