Search for etcd in PATH, don't install if installed#5427
Merged
morgo merged 5 commits intovitessio:masterfrom Nov 15, 2019
Merged
Search for etcd in PATH, don't install if installed#5427morgo merged 5 commits intovitessio:masterfrom
morgo merged 5 commits intovitessio:masterfrom
Conversation
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Contributor
Author
|
I checked this with: The prepared statement test currently fails (expected), and I had to re-run the mysql57.backup_mysqlctld test.. but it otherwise passes :-) |
Contributor
Author
|
A bug was discovered in this, where the scripts are not compatible with etcd 3.4. Since this changes to not install etcd if it's installed, it will break if the system has etcd 3.4 installed. I will followup and figure out what we need to fix. |
This was referenced Nov 25, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revision of #5365
I have changed from strictly "make it a prerequisite" to "only install it if not present".
I resumed this PR because I noticed that we also distribute etcd in the Vitess packages. This PR is required to transition out of that. I think it is important to not ship 3rd party software (unless it is compiled in such as a library) because then Vitess is on the hook for security updates.
All the install and contributor guides already add $VTROOT/bin to $PATH, so switching to require it in path should work fine vs. ETCD_BINDIR.