Skip to content

Make etcd a preinstall dependency#5365

Closed
morgo wants to merge 4 commits intovitessio:masterfrom
planetscale:morgo-etcd-as-prereq
Closed

Make etcd a preinstall dependency#5365
morgo wants to merge 4 commits intovitessio:masterfrom
planetscale:morgo-etcd-as-prereq

Conversation

@morgo
Copy link
Copy Markdown
Contributor

@morgo morgo commented Oct 27, 2019

This changes the bootstrap, so I've verified with:

make docker_bootstrap && make docker_test flavor=mysql57

We will need to update the documentation to say that etcd should be pre-installed, similar to mysql-server. I have PRs in progress for it under both the local guide and the contributing guide: vitessio/website#316
vitessio/website#309

The motivation here is that if something is reliably available in repos, we should get out of the business of managing it - there could be vulnerabilities, failures in the install process, etc.

Signed-off-by: Morgan Tocker tocker@gmail.com

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo requested a review from sougou as a code owner October 27, 2019 21:05
@morgo morgo added this to the v5.0 milestone Oct 27, 2019
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@deepthi
Copy link
Copy Markdown
Collaborator

deepthi commented Oct 28, 2019

Docker tests should be run with-pull=false to use the local image, otherwise the image is pulled from dockerhub. There doesn't seem to be a way to pass this to make docker_test, it always pulls the image.
The alternative way of doing that is to do go run test.go -pull=false. Flavor defaults to mysql57.

morgo added 2 commits October 31, 2019 08:16
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Nov 5, 2019

I am running go run test.go -pull=false now. The prepared statements test may fail, since it fails for me in master after a new bootstrap, but I'll verify no other tests fail.

@morgo
Copy link
Copy Markdown
Contributor Author

morgo commented Nov 5, 2019

It looks like etcd is not available in Debian Stretch (2017), so this patch won't work as planned :( I am going to close it for now, and re-evaluate when we migrate the test suites to Golang. This will help us bump the base-image OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants