Closed
Conversation
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Collaborator
|
Docker tests should be run with |
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Contributor
Author
|
I am running |
Contributor
Author
|
It looks like etcd is not available in Debian Stretch (2017), so this patch won't work as planned :( I am going to close it for now, and re-evaluate when we migrate the test suites to Golang. This will help us bump the base-image OS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the bootstrap, so I've verified with:
We will need to update the documentation to say that
etcdshould be pre-installed, similar tomysql-server. I have PRs in progress for it under both the local guide and the contributing guide: vitessio/website#316vitessio/website#309
The motivation here is that if something is reliably available in repos, we should get out of the business of managing it - there could be vulnerabilities, failures in the install process, etc.
Signed-off-by: Morgan Tocker tocker@gmail.com