Merged
Conversation
sougou
force-pushed
the
ss-vrepl-vdiff
branch
from
3d2f6ff to
156343f
Compare
deepthi
reviewed
Oct 31, 2019
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
LGTM. A few questions inline.
go/vt/mysqlctl/replication.go
Outdated
Collaborator
There was a problem hiding this comment.
If this condition is false, we fall through to WaitUntilPositionCommand. Is that safe?
Contributor
Author
There was a problem hiding this comment.
It should not happen for master because it will always be up-to-date. Even if it does, the wait command will just return an error, which is fine.
go/vt/mysqlctl/fileutil.go
Outdated
Contributor
Author
There was a problem hiding this comment.
I plan to address these as part of the V2 and SBR cleanups.
go/vt/vtctl/vtctl.go
Outdated
Collaborator
There was a problem hiding this comment.
Does order matter? Does <target keyspace> need to be at the end?
Contributor
Author
There was a problem hiding this comment.
Order doesn't matter. The ordering of the help line implies that workflow is a mandatory flag and target_keyspace is a mandatory argument. The rest are optional.
go/vt/wrangler/vdiff_test.go
Outdated
deepthi
approved these changes
Nov 2, 2019
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
It now waits indefinitely until at least one tablet is available. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
It now picks equally from all tablet types. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
* WaitForPos previously worked only for replicas. It's been updated to work correctly for masters also. * resultReader keyspace was hardcoded to source. The keyspace name is now passed as input param. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Some tests still depend on the healthcheck timeout options. So, tablet picker still needs to accept them as arguments. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-vrepl-vdiff
branch
2 times, most recently
from
e9ad938 to
09987c4
Compare
change test to handle new mastership rules Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-vrepl-vdiff
branch
from
09987c4 to
7d8a08d
Compare
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
sougou
force-pushed
the
ss-vrepl-vdiff
branch
from
33fe9a0 to
1b8bece
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements vdiff, which can compare the source and target tables of a workflow.
This works for only for deterministic streams. Non-deterministic streams are likely to report differences.
Doesn't look like this change can be broken out into smaller pieces.