VDiff v2 Blog Post#1219

Merged

mattlord merged 12 commits intoprodfrom

Nov 22, 2022

Member

mattlord commented Nov 10, 2022 •

edited

Loading

Link: https://deploy-preview-1219--vitess.netlify.app/blog/2022-11-22-vdiff-v2/

mattlord requested review from deepthi and rohit-nayak-ps

November 10, 2022 17:54

mattlord force-pushed the vdiff2_blog branch from 316d8fa to 98f8fdd Compare

November 10, 2022 17:56

netlify bot commented Nov 10, 2022

✅ Deploy Preview for vitess ready!

Name	Link
🔨 Latest commit	`316d8fa`
🔍 Latest deploy log	https://app.netlify.com/sites/vitess/deploys/636d3ac18583a40009a22e88
😎 Deploy Preview	https://deploy-preview-1219--vitess.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Nov 10, 2022 •

edited

Loading

✅ Deploy Preview for vitess ready!

Name	Link
🔨 Latest commit	`5cdea5a`
🔍 Latest deploy log	https://app.netlify.com/sites/vitess/deploys/637cded9051b3200087d50ad
😎 Deploy Preview	https://deploy-preview-1219--vitess.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mattlord force-pushed the vdiff2_blog branch from 98f8fdd to 7c08fec Compare

November 10, 2022 18:04

mattlord requested a review from GuptaManan100

November 10, 2022 18:05

mattlord force-pushed the vdiff2_blog branch 2 times, most recently from d26cb5b to a71ba5f Compare

November 10, 2022 18:17


          Initial preface content

bf5a363

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vdiff2_blog branch from a71ba5f to bf5a363 Compare

November 10, 2022 18:20

maxenglander reviewed

View reviewed changes

Collaborator

maxenglander left a comment

Looks good to me! Offered some personal preferences in terms of wording choices and sentence structure, won't be offended if you disregard all of them.

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

mattlord force-pushed the vdiff2_blog branch 5 times, most recently from 54d15b7 to f45e25a Compare

November 10, 2022 19:56


          Add VDiff content

60b7307

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vdiff2_blog branch from f45e25a to 60b7307 Compare

November 10, 2022 20:10


          Incorporate Max's feedback

342fa56

Signed-off-by: Matt Lord <mattalord@gmail.com>

Member Author

mattlord commented Nov 10, 2022

Looks good to me! Offered some personal preferences in terms of wording choices and sentence structure, won't be offended if you disregard all of them.

Thanks, @maxenglander ! I've incorporated your feedback here: 342fa56

mattlord force-pushed the vdiff2_blog branch 4 times, most recently from 6de15f4 to 33042b5 Compare

November 10, 2022 22:06


          More minor tweaks

a6d3337

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vdiff2_blog branch from 33042b5 to a6d3337 Compare

November 10, 2022 22:40

mattlord marked this pull request as ready for review

November 11, 2022 17:08


          Modify title and description

57ee896

Signed-off-by: Matt Lord <mattalord@gmail.com>

rohit-nayak-ps reviewed

View reviewed changes

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

mattlord force-pushed the vdiff2_blog branch 11 times, most recently from b46a7bb to 7775415 Compare

November 14, 2022 19:38


          Add basic algo/flow for VDiff1

ed6efe3

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vdiff2_blog branch from 7775415 to ed6efe3 Compare

November 14, 2022 19:39

deepthi approved these changes

View reviewed changes

Collaborator

deepthi left a comment

Looks like feedback from @rohit-nayak-ps has been incorporated?
LGTM except for some comments. Once those are addressed (and maybe another round of review from Rohit), we can go ahead with this.

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved


          Update content/en/blog/2022-11-14-vdiff-v2.md

Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord requested a review from rohit-nayak-ps

November 16, 2022 16:44

mattlord force-pushed the vdiff2_blog branch from 4b37cdd to fab907e Compare

November 16, 2022 16:59

mattlord requested a review from maxenglander

November 16, 2022 23:43

mattlord force-pushed the vdiff2_blog branch from fab907e to 29130db Compare

November 16, 2022 23:45


          Minor tweaks

91034a8

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the vdiff2_blog branch from 29130db to 91034a8 Compare

November 16, 2022 23:47

rohit-nayak-ps approved these changes

View reviewed changes

Member

rohit-nayak-ps left a comment

Looks great!

The image on the top right looks a bit out of place. It is not related to the main idea of the blog post. I know you mentioned it is related to the first line (keyspaces/shards/logical database) ...
@deepthi, wdyt?

content/en/blog/2022-11-14-vdiff-v2.md Outdated Show resolved Hide resolved


          Add vtgate concept link

abed0ac

Signed-off-by: Matt Lord <mattalord@gmail.com>

Member Author

mattlord commented Nov 17, 2022

Looks great!

The image on the top right looks a bit out of place. It is not related to the main idea of the blog post. I know you mentioned it is related to the first line (keyspaces/shards/logical database) ... @deepthi, wdyt?

I'm OK either way. I thought it might help to have a visual representation of the "single logical MySQL instance view" of the fleet concept mentioned there. But I added a link to the VTGate concept page there too.


          Remove errant comma in SELECT

f16b19c

Signed-off-by: Matt Lord <mattalord@gmail.com>

Collaborator

deepthi commented Nov 21, 2022

Looks great!
The image on the top right looks a bit out of place. It is not related to the main idea of the blog post. I know you mentioned it is related to the first line (keyspaces/shards/logical database) ... @deepthi, wdyt?

I'm OK either way. I thought it might help to have a visual representation of the "single logical MySQL instance view" of the fleet concept mentioned there. But I added a link to the VTGate concept page there too.

I agree with Rohit on this. Let's remove that graphic.

mattlord added 2 commits

November 21, 2022 17:18


          Remove image and add shout-out to Arthur

bd8ed44

Signed-off-by: Matt Lord <mattalord@gmail.com>


          Update publish date

5cdea5a

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord merged commit ffbea0d into prod

mattlord deleted the vdiff2_blog branch

November 22, 2022 14:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet