fix flaky test and unit_race failure#5187
Merged
deepthi merged 2 commits intovitessio:masterfrom Sep 13, 2019
Merged
Conversation
sougou
approved these changes
Sep 13, 2019
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Heh. I had fixed this in my branch. I'll undo it on my side.
Collaborator
Author
|
Also fix unit_race failure in CI. |
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
ds-fix-flaky-test
branch
from
0106706 to
91e4977
Compare
Collaborator
Author
|
rebased to get #5185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBuildPlayerPlanNoDup is failing intermittently because the order of tables in the error message varies.
This PR changes the asserting to check for a substring instead of an exact match.
Before:
After:
Signed-off-by: deepthi deepthi@planetscale.com