docker/bootstrap: Add back VT_MYSQL_ROOT.#5185
Merged
sougou merged 2 commits intovitessio:masterfrom Sep 13, 2019
Merged
Conversation
Contributor
|
Sorry, this is my bad. It was removed in #5109 Is it possible to add CI so that it will fail if broken? |
Without this, all tests fail because Vitess can't find mysqld:
failed init mysql: mysqld not found in any of
/vt/{sbin,bin,libexec,scripts}
Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Since all Go tools have been removed from bootstrap. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
7266fdf to
f97a82b
Compare
sougou
approved these changes
Sep 13, 2019
Contributor
sougou
left a comment
There was a problem hiding this comment.
Forcing this through to fix broken build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, all tests fail because Vitess can't find mysqld: