Skip to content

healthcheck after backup should be run only for offline backups #5129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 2 commits into from
Aug 26, 2019
+4 −2
Merged

healthcheck after backup should be run only for offline backups #5129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d221b9c
healthcheck after backup should be run only for offline backups
deepthi Aug 23, 2019
0c48dee
check that actionMutex is locked before running healthcheck
deepthi Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/vt/vttablet/tabletmanager/healthcheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ func (agent *ActionAgent) runHealthCheck() {
}

func (agent *ActionAgent) runHealthCheckLocked() {
agent.checkLock()
// read the current tablet record and tablet control
agent.mutex.Lock()
tablet := proto.Clone(agent._tablet).(*topodatapb.Tablet)
Expand Down
5 changes: 3 additions & 2 deletions go/vt/vttablet/tabletmanager/rpc_backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,10 @@ func (agent *ActionAgent) Backup(ctx context.Context, concurrency int, logger lo
if err := agent.refreshTablet(bgCtx, "after backup"); err != nil {
return err
}
// and re-run health check to be sure to capture any replication delay
// not needed for online backups because it will continue to run per schedule
agent.runHealthCheckLocked()
}
// and re-run health check to be sure to capture any replication delay
agent.runHealthCheckLocked()

return returnErr
}
Expand Down