healthcheck after backup should be run only for offline backups#5129
Merged
sougou merged 2 commits intovitessio:masterfrom Aug 26, 2019
Merged
healthcheck after backup should be run only for offline backups#5129sougou merged 2 commits intovitessio:masterfrom
sougou merged 2 commits intovitessio:masterfrom
Conversation
Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
sougou
approved these changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #5066
Since we no longer take the action lock while running online backups (aka xtrabackup), healthcheck will run on the normal schedule. Hence there is no need to call it explicitly when the backup finishes. Further, healthcheck is supposed to take the action lock before running, so it is incorrect to call
agent.runHealthCheckLocked()when we are not holding the action lock.Signed-off-by: deepthi deepthi@planetscale.com