Skip to content

Allow subclasses of GrpcClientFactory to modify channel builder #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
demmer merged 1 commit into from
Dec 10, 2018
Merged

Allow subclasses of GrpcClientFactory to modify channel builder #4439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions java/grpc-client/src/main/java/io/vitess/client/grpc/GrpcClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,39 @@ public GrpcClientFactory setNameResolverFactory(NameResolver.Factory value) {
*/
@Override
public RpcClient create(Context ctx, String target) {
NettyChannelBuilder channel = NettyChannelBuilder.forTarget(target)
.negotiationType(NegotiationType.PLAINTEXT)
.intercept(new RetryingInterceptor(config));
NettyChannelBuilder channel = channelBuilder(target)
.negotiationType(NegotiationType.PLAINTEXT)
.intercept(new RetryingInterceptor(config));
if (loadBalancerFactory != null) {
channel.loadBalancerFactory(loadBalancerFactory);
}
if (nameResolverFactory != null) {
channel.nameResolverFactory(nameResolverFactory);
}
return callCredentials != null ?
new GrpcClient(channel.build(), callCredentials) : new GrpcClient(channel.build());
new GrpcClient(channel.build(), callCredentials) : new GrpcClient(channel.build());
}

/**
* <p>This method constructs NettyChannelBuilder object that will be used to create RpcClient.<p/>
* <p>Subclasses may override this method to make adjustments to the builder<p/>
* for example:
* <code>
* @Override
* protected NettyChannelBuilder channelBuilder(String target) {
* return super.channelBuilder(target)
* .eventLoopGroup(new EpollEventLoopGroup())
* .withOption(EpollChannelOption.TCP_USER_TIMEOUT,30);
* }
*
* </code>
*
* @param target
* target is passed to NettyChannelBuilder which will resolve based on scheme, by default dns.
* @return
*/
protected NettyChannelBuilder channelBuilder(String target){
return NettyChannelBuilder.forTarget(target);
}

/**
Expand Down Expand Up @@ -152,7 +174,7 @@ public RpcClient createTls(Context ctx, String target, TlsOptions tlsOptions) {
}

return new GrpcClient(
NettyChannelBuilder.forTarget(target).negotiationType(NegotiationType.TLS).sslContext(sslContext).intercept(new RetryingInterceptor(config)).build());
channelBuilder(target).negotiationType(NegotiationType.TLS).sslContext(sslContext).intercept(new RetryingInterceptor(config)).build());
}

/**
Expand Down