Allow subclasses of GrpcClientFactory to modify channel builder#4439
Merged
demmer merged 1 commit intovitessio:masterfrom Dec 10, 2018
smourachov:grpc-java-allow-modify-channel-builder
Merged
Allow subclasses of GrpcClientFactory to modify channel builder#4439demmer merged 1 commit intovitessio:masterfrom smourachov:grpc-java-allow-modify-channel-builder
demmer merged 1 commit intovitessio:masterfrom
smourachov:grpc-java-allow-modify-channel-builder
Conversation
Signed-off-by: Serguei Mourachov <serguei@slack-corp.com>
demmer
approved these changes
Dec 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases we might need to adjust channel builder to set various config parameters or to share netty/grpc resources with other components.