Skip to content

Upgrade grpc-go to 1.15#4376

Merged
sougou merged 1 commit intovitessio:masterfrom
HubSpot:upgrade-grpc-to-1-15
Nov 21, 2018
Merged

Upgrade grpc-go to 1.15#4376
sougou merged 1 commit intovitessio:masterfrom
HubSpot:upgrade-grpc-to-1-15

Conversation

@leoxlin
Copy link
Copy Markdown

@leoxlin leoxlin commented Nov 20, 2018

The grpc-java we use in the client is upgraded to 1.15.0 in #4218

This upgrades the grpc-go server version to match the client version.

We've seen improvements to graceful closures on the upgrade as there had been numerous transport level bug fixes since 1.11.

cc @acharis

Signed-off-by: Leo Xuzhang Lin llin@hubspot.com

Signed-off-by: Leo Xuzhang Lin <llin@hubspot.com>
@leoxlin leoxlin requested a review from sougou as a code owner November 20, 2018 17:28
@demmer
Copy link
Copy Markdown
Member

demmer commented Nov 20, 2018

The latest release looks to be 1.16:
https://github.com/grpc/grpc-go/releases

Is there some reason we wouldn't want to upgrade to that?

@leoxlin
Copy link
Copy Markdown
Author

leoxlin commented Nov 20, 2018

We were a bit hesitant to upgrade to that internally since that release is less than a month old.

@sougou sougou merged commit e232f21 into vitessio:master Nov 21, 2018
@leoxlin leoxlin deleted the upgrade-grpc-to-1-15 branch November 29, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants