Skip to content

Upgrade Guava, Protobuf, gRPC, Netty, and others#4218

Merged
sougou merged 1 commit intovitessio:masterfrom
swankjesse:jwilson.0925.upgrade_deps
Sep 26, 2018
Merged

Upgrade Guava, Protobuf, gRPC, Netty, and others#4218
sougou merged 1 commit intovitessio:masterfrom
swankjesse:jwilson.0925.upgrade_deps

Conversation

@swankjesse
Copy link
Copy Markdown

grpc from 1.11 to 1.15
protobuf from 3.0.0 to 3.5.1
jsr305 from 3.0.0 to 3.0.2
gson from 2.8.0 to 2.8.5
guava from 20.0 to 26.0-jre
commons-io from 2.5 to 2.6
netty from 4.1.22 to 4.1.27
joda-time from 2.5 to 2.10
commons-collections4 from 4.1 to 4.2

grpc from 1.11 to 1.15
protobuf from 3.0.0 to 3.5.1
jsr305 from 3.0.0 to 3.0.2
gson from 2.8.0 to 2.8.5
guava from 20.0 to 26.0-jre
commons-io from 2.5 to 2.6
netty from 4.1.22 to 4.1.27
joda-time from 2.5 to 2.10
commons-collections4 from 4.1 to 4.2

Signed-off-by: Jesse Wilson <jwilson@squareup.com>
Copy link
Copy Markdown
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sougou sougou merged commit 73fcbf2 into vitessio:master Sep 26, 2018
@tirsen
Copy link
Copy Markdown
Collaborator

tirsen commented Sep 30, 2018

Should we switch to third party package shadowing? That way we don’t get in this sort of trouble that we did with Guava again.

@swankjesse
Copy link
Copy Markdown
Author

I think it'd be sufficient to just avoid @Beta APIs going forward. We should also encourage the Guava maintainers to remove @Beta from critical classes like Futures.

@leoxlin leoxlin mentioned this pull request Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants