Skip to content

get mysql-workbench working with vtgate #4359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 3 commits into from
Nov 16, 2018
Merged

get mysql-workbench working with vtgate #4359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2581bfa
WIP: mysql-workbench queries
deepthi Nov 13, 2018
f0e20ce
check expected results of newly supported queries
deepthi Nov 13, 2018
8009a83
remove commented panic
deepthi Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go/vt/sqlparser/ast.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3105,6 +3105,7 @@ type ConvertType struct {
// this string is "character set" and this comment is required
const (
CharacterSetStr = " character set"
CharsetStr = "charset"
)

// Format formats the node.
Expand Down
10 changes: 8 additions & 2 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,10 +1020,16 @@ var (
output: "show binlog",
}, {
input: "show character set",
output: "show character set",
output: "show charset",
}, {
input: "show character set like '%foo'",
output: "show character set",
output: "show charset",
}, {
input: "show charset",
output: "show charset",
}, {
input: "show charset like '%foo'",
output: "show charset",
}, {
input: "show collation",
output: "show collation",
Expand Down
Loading