Skip to content

get mysql-workbench working with vtgate#4359

Merged
sougou merged 3 commits intovitessio:masterfrom
planetscale:ds-mysql-workbench
Nov 16, 2018
Merged

get mysql-workbench working with vtgate#4359
sougou merged 3 commits intovitessio:masterfrom
planetscale:ds-mysql-workbench

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Nov 13, 2018

Implement several queries needed for mysql-workbench to connect to vtgate.
We are returning either an empty resultset or minimal results for these queries. For example: show engines will return 1 row with InnoDB.
This may not be sufficient for all use cases.

Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner November 13, 2018 21:55
@deepthi deepthi changed the title WIP get mysql-workbench working with vtgate WIP: get mysql-workbench working with vtgate Nov 13, 2018
Copy link
Copy Markdown
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

@sougou sougou changed the title WIP: get mysql-workbench working with vtgate get mysql-workbench working with vtgate Nov 15, 2018
Signed-off-by: deepthi <deepthi@planetscale.com>
@dveeden
Copy link
Copy Markdown
Contributor

dveeden commented Nov 16, 2018

I tried this with MySQL Workbench 8.0.13 and I was able to connect and run a few queries without any issue.
Thanks!

@sougou sougou merged commit c505bf2 into vitessio:master Nov 16, 2018
@deepthi deepthi deleted the ds-mysql-workbench branch December 5, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants