enable query logging to file in the local examples#4152
Merged
sougou merged 1 commit intovitessio:masterfrom Sep 24, 2018
Merged
enable query logging to file in the local examples#4152sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
sougou
reviewed
Aug 24, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Can you think of a way to warn people that this should not be used in production, or at least inform them of its cost?
sougou
approved these changes
Sep 24, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
Going to merge this. Hopefully, those going into production will remember to disable this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this useful when testing #4151 and figured for the local example we might as well include the query logging to show off how it all works.