rework the grpc callinfo to include the peer remote address#4151
Merged
sougou merged 1 commit intovitessio:masterfrom Aug 24, 2018
Merged
rework the grpc callinfo to include the peer remote address#4151sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
Since grpc has a convenient method for getting the peer information from the context, add the necessary hooks to extract this for the vitess Callinfo interface so it shows up in query logs and debug messages. Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
sougou
approved these changes
Aug 24, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
There's already a Remote function. How convenient :).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since grpc has a convenient method for getting the peer information
from the context, add the necessary hooks to extract this for the
vitess Callinfo interface so it shows up in query logs and debug
messages.
Signed-off-by: Michael Demmer mdemmer@slack-corp.com