Skip to content

Remove RefreshConfig() from backups #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 1 commit into from
Jul 25, 2018
Merged

Remove RefreshConfig() from backups #4101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions go/vt/mysqlctl/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,11 +322,6 @@ func backup(ctx context.Context, cnf *Mycnf, mysqld MysqlDaemon, logger logutil.
usable := backupErr == nil

// Try to restart mysqld
err = mysqld.RefreshConfig(ctx, cnf)
if err != nil {
return usable, fmt.Errorf("can't refresh mysqld config: %v", err)
}

err = mysqld.Start(ctx, cnf)
if err != nil {
return usable, fmt.Errorf("can't restart mysqld: %v", err)
Expand Down
1 change: 0 additions & 1 deletion go/vt/mysqlctl/mysql_daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ type MysqlDaemon interface {
Shutdown(ctx context.Context, cnf *Mycnf, waitForMysqld bool) error
RunMysqlUpgrade() error
ReinitConfig(ctx context.Context, cnf *Mycnf) error
RefreshConfig(ctx context.Context, cnf *Mycnf) error
Wait(ctx context.Context, cnf *Mycnf) error

// GetMysqlPort returns the current port mysql is listening on.
Expand Down