Remove RefreshConfig() from backups#4101
Merged
sougou merged 1 commit intovitessio:masterfrom Jul 25, 2018
Merged
Conversation
* Currently this is not having the intended behavior. Removing while adding a proper fix for this. This effectively reverts: vitessio#3063 Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Collaborator
|
Just an FYI, I did test the behavior with setting up the config/mycnf data to match my production /etc/mysql/my.cnf but I ran into an issue where the replacement my.cnf is owned by |
sougou
approved these changes
Jul 25, 2018
Contributor
sougou
left a comment
sougou
left a comment
There was a problem hiding this comment.
We should also eventually remove the function and the grpc support for it. But that can be part of the bigger cleanup. So, this is good for now.
I don't fully understand @tomkrouper's comment. But it seems orthogonal to this fix. So, I'll follow up separately with him.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
proper fix for this. This effectively reverts: Refresh MySQL config after a backup #3063