Skip to content

Fix bug found in dev around repairReplication patch in PR #4024 #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 1 commit into from
Jul 12, 2018
Merged

Fix bug found in dev around repairReplication patch in PR #4024 #4081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go/vt/vttablet/tabletmanager/orchestrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ func (orc *orcClient) InActiveShardRecovery(tablet *topodatapb.Tablet) (bool, er
return false, err
}

// Orchestrator returns a 0-length response when it has no history of recovery on this cluster.
if len(r) == 0 {
return false, fmt.Errorf("Orchestrator returned an empty audit-recovery response")
return false, nil
}

active, ok := r[0]["IsActive"].(bool)
Expand Down