Fix bug found in dev around repairReplication patch in PR #4024#4081
Merged
sougou merged 1 commit intovitessio:masterfrom Jul 12, 2018
Conversation
active-recovery response when it has no history of recovery on that cluster. Signed-off-by: Maggie Zhou <mzhou@slack-corp.com>
zmagg
force-pushed
the
fix-repair-replication-orc-active-recovery-empty-response
branch
from
5a4f6cc to
d5b2279
Compare
sougou
approved these changes
Jul 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in the repairReplication #4024 where replica tablets sometimes do not reconnect replication to the master tablet after restarting. This bug is triggered when Orchestrator has never recovered the shard the tablet is a member of.
This fixes the bug by allowing repairReplication to continue when
audit-recoveryreturns an empty response, as an empty response indicates that Orchestrator is not actively recovering that shard, and has never recovered the shard before. Previously, #4024 assumed an empty response was an error and skipped repairReplication after getting an empty response back from Orchestrator'saudit-recoveryendpoint.