Skip to content

jdbc: set type of BigInteger as VARCHAR #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 2 commits into from
May 19, 2018
Merged

jdbc: set type of BigInteger as VARCHAR #3940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff47c5
Follow on to PR#3914, we set type of BigInteger as UINT64 instead of …
May 16, 2018
a36f37c
declare BigInteger type as VARCHAR
May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion java/client/src/main/java/io/vitess/client/Proto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,13 @@ protected static class TypedValue {
this.type = Query.Type.VARBINARY;
this.value = ByteString.copyFrom((byte[]) value);
} else if (value instanceof Integer || value instanceof Long || value instanceof Short
|| value instanceof Byte || value instanceof BigInteger) {
|| value instanceof Byte ) {
// Int32, Int64, Short, Byte
this.type = Query.Type.INT64;
this.value = ByteString.copyFromUtf8(value.toString());
} else if (value instanceof BigInteger) {
this.type = Query.Type.VARCHAR;
this.value = ByteString.copyFromUtf8(value.toString());
} else if (value instanceof UnsignedLong) {
// Uint64
this.type = Query.Type.UINT64;
Expand Down
2 changes: 1 addition & 1 deletion java/client/src/test/java/io/vitess/client/BindVarTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public static Collection<Object[]> testParams() {
BindVariable.newBuilder().setType(Query.Type.DECIMAL)
.setValue(ByteString.copyFromUtf8("0.000000000123456789123456789")).build()},
{new BigInteger("123456789123456789"),
BindVariable.newBuilder().setType(Query.Type.INT64)
BindVariable.newBuilder().setType(Query.Type.VARCHAR)
.setValue(ByteString.copyFromUtf8("123456789123456789")).build()},
// List of Int
{Arrays.asList(1, 2, 3),
Expand Down