jdbc: set type of BigInteger as VARCHAR

[acharis]

Signed-off-by: Alex Charis acharis@hubspot.com

[harshit-gangal]

In Mysql Bigint can have negative value hence it was kept as INT64.
Min Value : -2^63
Max Value : 2^63-1

[acharis]

yeah, i'm not really sure what the right thing to do is...we're mapping a Java BigInteger, which provides arbitrary precision signed integers, onto a mysql bigint, which can be signed or unsigned and has limited precision. and i'm guessing we don't know which we're mapping to at this point in the code.

[harshit-gangal]

@acharis Do you have reason for changing this to UINT64? Is it breaking things?
BigInteger can hold negative value which is same with Mysql.

We can think of sending it as string. Can you validate that.

[acharis]

Yes, things are broken as-is and this fixes them. Tested internally.

That being said, as above, I'm not sure what the right fix is.

[harshit-gangal]

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[harshit-gangal]

LGTM