Factor out glog references for ease of dropping in an adapter to a di…#3855
Merged
michael-berlin merged 1 commit intovitessio:masterfrom Apr 21, 2018
Merged
Conversation
michael-berlin
force-pushed
the
restore_glog_change
branch
from
ce9f9d8 to
3d8b64d
Compare
…fferent logging library. Note: This is the revert of a temporary revert and has the same effect as the original PR: vitessio#3830 Revert "Revert "Factor out glog references"" This reverts commit 246e289. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
michael-berlin
force-pushed
the
restore_glog_change
branch
from
3d8b64d to
e6b1e31
Compare
Contributor
|
❤️ @vmg and I had issues with the vitess logger before, this is a good step IMO |
sougou
approved these changes
Apr 21, 2018
Contributor
Author
|
Credit goes to David Weitzman. I am just re-merging this after I had to temporarily revert the original PR earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fferent logging library.
Note: This is the revert of a temporary revert and has the same effect
as the original PR: #3830
Revert "Revert "Factor out glog references""
This reverts commit 246e289.
Signed-off-by: David Weitzman dweitzman@pinterest.com