Merged
Conversation
…fferent logging library. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
dweitzman
force-pushed
the
factor_out_logs
branch
from
8231699 to
b0cedf1
Compare
alainjobart
approved these changes
Apr 18, 2018
Contributor
|
Restarted the failing test, we'll see how that goes. |
Contributor
|
Sugu, I'll temporarily revert this because it creates a merge conflict with another PR I'm in the process of importing locally. |
Contributor
|
That PR to be precise: #3784 |
michael-berlin
pushed a commit
to michael-berlin/vitess
that referenced
this pull request
Apr 21, 2018
…fferent logging library. Note: This is the revert of a temporary revert and has the same effect as the original PR: vitessio#3830 Revert "Revert "Factor out glog references"" This reverts commit 246e289. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
mcuadros
pushed a commit
to src-d/go-vitess
that referenced
this pull request
Sep 25, 2018
…fferent logging library. Note: This is the revert of a temporary revert and has the same effect as the original PR: vitessio/vitess#3830 Revert "Revert "Factor out glog references"" This reverts commit 246e2898d21e27ab88df6ca70fde7b95c42aa0cd. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
mcuadros
pushed a commit
to src-d/go-vitess
that referenced
this pull request
Sep 25, 2018
…fferent logging library. Note: This is the revert of a temporary revert and has the same effect as the original PR: vitessio/vitess#3830 Revert "Revert "Factor out glog references"" This reverts commit 246e2898d21e27ab88df6ca70fde7b95c42aa0cd. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify dropping in an adapter to a different logging library.
Signed-off-by: David Weitzman dweitzman@pinterest.com