Skip to content

add log message if new tablet doesn't have a sufficiently new timesta… #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sougou merged 2 commits into from
Aug 17, 2017
Merged

add log message if new tablet doesn't have a sufficiently new timesta… #3084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5339b7
add log message if new tablet doesn't have a sufficiently new timesta…
gentryx Aug 17, 2017
3f9f5f7
fix typo, add missing includes for log message
gentryx Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions go/vt/discovery/tablet_stats_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ package discovery
import (
"sync"

log "github.com/golang/glog"
querypb "github.com/youtube/vitess/go/vt/proto/query"
topodatapb "github.com/youtube/vitess/go/vt/proto/topodata"
"github.com/youtube/vitess/go/vt/topo/topoproto"
)

// TabletStatsCache is a HealthCheckStatsListener that keeps both the
Expand Down Expand Up @@ -193,9 +195,13 @@ func (tc *TabletStatsCache) StatsUpdate(ts *TabletStats) {

// We already have one up server, see if we
// need to replace it.
if e.healthy[0].TabletExternallyReparentedTimestamp > ts.TabletExternallyReparentedTimestamp {
// The notification we just got is older than
// the one we had before, discard it.
if ts.TabletExternallyReparentedTimestamp < e.healthy[0].TabletExternallyReparentedTimestamp {
log.Warningf("not marking healthy master as Up because its externally reparented timestamp is smaller than the highest known timestamp from previous MASTERs: %d < %d ",
ts.TabletExternallyReparentedTimestamp,
e.healthy[0].TabletExternallyReparentedTimestamp,
topoproto.KeyspaceShardString(ts.Target.Keyspace, ts.Target.Shard),
topoproto.TabletAliasString(ts.Tablet.Alias),
topoproto.TabletAliasString(e.healthy[0].Tablet.Alias))
return
}

Expand Down