add log message if new tablet doesn't have a sufficiently new timesta…#3084
Merged
sougou merged 2 commits intovitessio:masterfrom Aug 17, 2017
Merged
add log message if new tablet doesn't have a sufficiently new timesta…#3084sougou merged 2 commits intovitessio:masterfrom
sougou merged 2 commits intovitessio:masterfrom
Conversation
…mp to be marked up
alainjobart
reviewed
Aug 17, 2017
| // The notification we just got is older than | ||
| // the one we had before, discard it. | ||
| if ts.TabletExternallyReparentedTimestamp < e.healthy[0].TabletExternallyReparentedTimestamp { | ||
| log.Warningf("not marking healthy master as Up because its externally reparented timestamt is smaller than the highest known timestamp from previous MASTERs: %d < %d ", |
alainjobart
reviewed
Aug 17, 2017
| // The notification we just got is older than | ||
| // the one we had before, discard it. | ||
| if ts.TabletExternallyReparentedTimestamp < e.healthy[0].TabletExternallyReparentedTimestamp { | ||
| log.Warningf("not marking healthy master as Up because its externally reparented timestamt is smaller than the highest known timestamp from previous MASTERs: %d < %d ", |
Contributor
There was a problem hiding this comment.
Also need to add a few imports to fix build.
Contributor
Author
|
Ugh, I forgot you'd be seeing this even though CI hasn't completed yet. Sorry about the noise. I'll ping you here once the patch is at least compiling. :-) |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mp to be marked up