Skip to content

Upgrade libperconaserverclient22 to libperconaserverclient24#19631

Merged
mhamza15 merged 1 commit intovitessio:mainfrom
mhamza15:percona
Mar 12, 2026
Merged

Upgrade libperconaserverclient22 to libperconaserverclient24#19631
mhamza15 merged 1 commit intovitessio:mainfrom
mhamza15:percona

Conversation

@mhamza15
Copy link
Copy Markdown
Collaborator

Description

Fixes the Dockerfile.percona84 build which broke today when Percona released 8.4.8-8. Percona Server 8.4.8 bumped the client library soname from 22 to 24.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Fixes the Dockerfile.percona84 build which broke today when Percona released 8.4.8-8. Percona Server 8.4.8 bumped the client library soname from 22 to 24.

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@mhamza15 mhamza15 self-assigned this Mar 12, 2026
@github-actions github-actions bot added this to the v24.0.0 milestone Mar 12, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 12, 2026
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Mar 12, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@mhamza15 mhamza15 marked this pull request as ready for review March 12, 2026 22:15
@mhamza15 mhamza15 added Component: Build/CI Type: CI/Build Backport to: release-22.0 Needs to be backport to release-22.0 Backport to: release-23.0 Needs to be backport to release-23.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required Component: Docker labels Mar 12, 2026
@mhamza15 mhamza15 requested review from Copilot, nickvanw and timvaillancourt and removed request for derekperkins and frouioui March 12, 2026 22:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Percona Server 8.4 Docker build dependencies to reflect Percona Server 8.4.8-8’s client library SONAME bump, fixing Dockerfile.percona84 image builds that started failing due to the renamed client package.

Changes:

  • Switch Percona 8.4 dependency from libperconaserverclient22 to libperconaserverclient24.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@mhamza15 mhamza15 merged commit dbd0dfe into vitessio:main Mar 12, 2026
134 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport to: release-22.0 Needs to be backport to release-22.0 Backport to: release-23.0 Needs to be backport to release-23.0 Component: Build/CI Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants