vtgate: set ServerStatusAutocommit in handshake status flags#19628
Merged
arthurschreiber merged 2 commits intovitessio:mainfrom Mar 16, 2026
Merged
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Match VTGate's default session state (Autocommit: true) in the initial handshake packet. Without this, clients that read handshake status flags misdetect autocommit as OFF and may skip sending SET AUTOCOMMIT=0. Fixes vitessio#19627 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Liz van Dijk <liz@planetscale.com>
a676370 to
e43ffb1
Compare
mhamza15
approved these changes
Mar 12, 2026
Collaborator
|
I've added the backport labels, so that'll handle backporting. Thank you! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19628 +/- ##
===========================================
+ Coverage 69.67% 84.48% +14.81%
===========================================
Files 1614 306 -1308
Lines 216793 54840 -161953
===========================================
- Hits 151044 46332 -104712
+ Misses 65749 8508 -57241
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arthurschreiber
approved these changes
Mar 12, 2026
Collaborator
|
@lizztheblizz You'll need to merge in main to pull in #19631 to fix the failing CI 🙇♂️ |
…e-autocommit-status
vitess-bot bot
added a commit
that referenced
this pull request
Mar 16, 2026
Signed-off-by: Liz van Dijk <liz@planetscale.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
vitess-bot bot
added a commit
that referenced
this pull request
Mar 16, 2026
Signed-off-by: Liz van Dijk <liz@planetscale.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
maxenglander
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 25, 2026
…o#19628) Signed-off-by: Liz van Dijk <liz@planetscale.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #5825 / PR #6551, which fixed status flags on query response packets but not the initial handshake.
Sets
SERVER_STATUS_AUTOCOMMITinNewConnection()so the handshake packet reflects VTGate's default session state (Autocommit: true). Without this, clients that read the handshake flags (pymysql, Connector/J, etc.) misdetect the server as autocommit=OFF and may skip sendingSET AUTOCOMMIT=0.Backporting probably wouldn't hurt, but I'm not sure how to do that. 😅
Related Issue(s)
Fixes #19627
Checklist
and on CI?Deployment Notes
N/A
AI Disclosure
This PR was co-authored with Claude Code. The bug was identified through manual investigation of VTGate's MySQL protocol handshake behavior.