Docker: Address build file CI warnings

[mattlord]

Description

This addresses the following warnings that we've been getting for our docker files:

FROM --platform flag should not use a constant value
FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Legacy key/value format with whitespace separator should not be used
LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[Copilot]

Pull request overview

This PR updates Vitess’ Docker build definitions to eliminate Dockerfile linter warnings by removing hard-coded FROM --platform=linux/amd64 values and switching legacy ENV key value syntax to ENV key=value in the lite images.

Changes:

• Replace constant --platform=linux/amd64 with --platform=${BUILDPLATFORM} across multiple Dockerfiles.
• Update ENV statements in docker/lite/* Dockerfiles to the non-legacy key=value format.
• Add a default BUILDPLATFORM export to build.env.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
docker/vttestserver/Dockerfile.mysql84	Switches FROM --platform to ${BUILDPLATFORM} for builder and final stages.
docker/vttestserver/Dockerfile.mysql80	Switches FROM --platform to ${BUILDPLATFORM} for builder and final stages.
docker/lite/Dockerfile.percona84	Switches FROM --platform to ${BUILDPLATFORM}; updates ENV to key=value.
docker/lite/Dockerfile.percona80	Switches FROM --platform to ${BUILDPLATFORM}; updates ENV to key=value.
docker/lite/Dockerfile.mysql84	Switches FROM --platform to ${BUILDPLATFORM}; updates ENV to key=value.
docker/lite/Dockerfile.mysql80	Switches FROM --platform to ${BUILDPLATFORM}; updates ENV to key=value.
docker/lite/Dockerfile	Switches FROM --platform to ${BUILDPLATFORM}; updates ENV to key=value.
docker/bootstrap/Dockerfile.percona84	Switches FROM --platform to ${BUILDPLATFORM}.
docker/bootstrap/Dockerfile.percona80	Switches FROM --platform to ${BUILDPLATFORM}.
docker/bootstrap/Dockerfile.mysql84	Switches FROM --platform to ${BUILDPLATFORM}.
docker/bootstrap/Dockerfile.mysql80	Switches FROM --platform to ${BUILDPLATFORM}.
docker/bootstrap/Dockerfile.common	Switches FROM --platform to ${BUILDPLATFORM}.
build.env	Exports BUILDPLATFORM with a default of linux/amd64.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 10 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[arthurschreiber]

This addresses the warnings, but I'm not sure I like the solution. 😅

How do you feel about adding --platform=linux/amd64 explicitly when we call docker build, and removing the --platform argument inside the Dockerfiles? 🤔

I also noticed that Percona actually publishes official ARM builds for their packages, so I guess we could publish amd64 and arm64 builds for those container images (not as part of this PR, of course).

[mattlord]

This addresses the warnings, but I'm not sure I like the solution. 😅

How do you feel about adding --platform=linux/amd64 explicitly when we call docker build, and removing the --platform argument inside the Dockerfiles? 🤔

I also noticed that Percona actually publishes official ARM builds for their packages, so I guess we could publish amd64 and arm64 builds for those container images (not as part of this PR, of course).

What don't you like? What do you think would be better? Note that we do currently have this in the Makefile:

define build_docker_image
        ${info Building ${2}}
        # Fix permissions before copying files, to avoid AUFS bug other must have read/access permissions
        chmod -R o=rx *;

        if grep -q arm64 <<< ${2}; then \
                echo "Building docker using arm64 buildx"; \
                docker buildx build --platform linux/arm64 -f ${1} -t ${2} --build-arg bootstrap_version=${BOOTSTRAP_VERSION} .; \
        elif [ $$(go env GOOS) != $$(go env GOHOSTOS) ] || [ $$(go env GOARCH) != $$(go env GOHOSTARCH) ]; then \
                echo "Building docker using buildx --platform=$$(go env GOOS)/$$(go env GOARCH)"; \
                docker buildx build --platform "$$(go env GOOS)/$$(go env GOARCH)" -f ${1} -t ${2} --build-arg bootstrap_version=${BOOTSTRAP_VERSION} .; \
        else \
                echo "Building docker using straight docker build"; \
                docker build -f ${1} -t ${2} --build-arg bootstrap_version=${BOOTSTRAP_VERSION} .; \
        fi
endef

You're suggesting we move the platform flag there for the amd64 builds as well? I'm good with that too. Let me know if I misunderstood. We'd have to do that in a few other places too, but not a big deal:

docker/bootstrap/build.sh:    docker build \
docker/bootstrap/docker-bake.hcl://   docker buildx bake -f docker/bootstrap/docker-bake.hcl
docker/bootstrap/docker-bake.hcl://   docker buildx bake -f docker/bootstrap/docker-bake.hcl --set *.tags=myregistry/bootstrap:mytag
docker/vttestserver/README.md:docker build -f docker/vtttestserver/Dockerfile.mysql80 -t vitess/vttestserver:v21.0.0-rc1-mysql80 .
go/mysql/collations/tools/colldump/colldump.sh:docker build --tag mysql-collation-data .
test/vtop_example.sh:docker build -f docker/lite/Dockerfile -t vitess/lite:pr .
test/vtop_example.sh:docker build -f docker/binaries/vtadmin/Dockerfile --build-arg VT_BASE_VER=pr -t vitess/vtadmin:pr ./docker/binaries/vtadmin

We know that we want to support ARM64, that has been an ongoing thing that I thought we might finally do for v24 (but the contact I was working with on the ARM side has gone quiet). This work resolves the linter warnings and removes our usage of deprecated things (which could be removed at any point), while also adding an ENV variable that can be used to build for other target platforms such as ARM64.

[arthurschreiber]

I think the failures will be fixed by #19371.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.65%. Comparing base (abc6891) to head (ced4dba).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #19363      +/-   ##
==========================================
- Coverage   69.67%   69.65%   -0.02%     
==========================================
  Files        1613     1614       +1     
  Lines      216459   216700     +241     
==========================================
+ Hits       150807   150937     +130     
- Misses      65652    65763     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.