Skip to content

[release-23.0] CI: Look for expected log message rather than code in Backup tests (#19199) #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattlord merged 3 commits into from
Jan 25, 2026
Merged

[release-23.0] CI: Look for expected log message rather than code in Backup tests (#19199) #19201

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ecd836
CI: Look for expected log message rather than code in Backup tests (#…
vitess-bot[bot] Jan 22, 2026
69af344
Merge branch 'release-23.0' into backport-19199-to-release-23.0
mattlord Jan 24, 2026
a693d07
Try adjusted Percona Server distro name
mattlord Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/test/endtoend/backup/vtbackup/backup_only_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ func verifyDisableEnableRedoLogs(ctx context.Context, t *testing.T, mysqlSocket

// MY-013600
// https://dev.mysql.com/doc/mysql-errors/8.0/en/server-error-reference.html#error_er_ib_wrn_redo_disabled
qr, err = conn.ExecuteFetch("SELECT 1 FROM performance_schema.error_log WHERE error_code = 'MY-013600'", 1, false)
qr, err = conn.ExecuteFetch("SELECT 1 FROM performance_schema.error_log WHERE data like '%InnoDB redo logging is disabled%'", 1, false)
require.NoError(t, err)
if len(qr.Rows) != 1 {
// Keep trying, possible we haven't disabled yet.
Expand All @@ -445,7 +445,7 @@ func verifyDisableEnableRedoLogs(ctx context.Context, t *testing.T, mysqlSocket

// MY-013601
// https://dev.mysql.com/doc/mysql-errors/8.0/en/server-error-reference.html#error_er_ib_wrn_redo_enabled
qr, err = conn.ExecuteFetch("SELECT 1 FROM performance_schema.error_log WHERE error_code = 'MY-013601'", 1, false)
qr, err = conn.ExecuteFetch("SELECT 1 FROM performance_schema.error_log WHERE data like '%InnoDB redo logging is enabled%'", 1, false)
require.NoError(t, err)
if len(qr.Rows) != 1 {
// Keep trying, possible we haven't disabled yet.
Expand Down
Loading