Skip to content

[main] Upgrade the Golang version to go1.25.6#19175

Closed
vitess-bot wants to merge 1 commit intomainfrom
upgrade-go-to-1.25.6-on-main
Closed

[main] Upgrade the Golang version to go1.25.6#19175
vitess-bot wants to merge 1 commit intomainfrom
upgrade-go-to-1.25.6-on-main

Conversation

@vitess-bot
Copy link
Contributor

This Pull Request bumps the Golang version to go1.25.6 and the bootstrap version to 50.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.

cc @vitessio/release

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vitess-bot vitess-bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Skip CI Skip CI actions from running Type: CI/Build labels Jan 19, 2026
@vitess-bot vitess-bot added the Benchmark me Add label to PR to run benchmarks label Jan 19, 2026
@vitess-bot vitess-bot added Component: General Changes throughout the code base Skip CI Skip CI actions from running go labels Jan 19, 2026
@vitess-bot vitess-bot requested a review from a team January 19, 2026 16:20
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 19, 2026

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@github-actions github-actions bot added this to the v24.0.0 milestone Jan 19, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 19, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 19, 2026
@timvaillancourt timvaillancourt added Type: Dependencies Dependency updates and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 19, 2026
@@ -1,4 +1,4 @@
FROM --platform=linux/amd64 golang:1.25.3-bookworm@sha256:414a753c2f67d0efccb01b5f58b3d3a8a2cbb7c012ce9e535418b5b3492b2c24
FROM --platform=linux/amd64 golang:1.25.6-bookworm@sha256:414a753c2f67d0efccb01b5f58b3d3a8a2cbb7c012ce9e535418b5b3492b2c24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this auto update is changing 3 -> 6 but the SHA is the same. That sounds wrong

Is this expected @frouioui?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to us pinning our dependencies/images by SHA recently: #19143. I'll see if I can fix up the automation to update the SHA as well, or alternatively, letting dependabot handle image updates. Only concern with allowing dependabot to do it is that it'll leave behind go.mod, so better off to do it this way most likely.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhamza15
Copy link
Collaborator

Closing to regenerate with digests using #19178

@mhamza15 mhamza15 closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Skip CI Skip CI actions from running Type: CI/Build Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants