Skip to content

Pin actions and docker images to SHAs#19143

Merged
mhamza15 merged 4 commits intovitessio:mainfrom
mhamza15:dep-shas
Jan 15, 2026
Merged

Pin actions and docker images to SHAs#19143
mhamza15 merged 4 commits intovitessio:mainfrom
mhamza15:dep-shas

Conversation

@mhamza15
Copy link
Collaborator

@mhamza15 mhamza15 commented Jan 14, 2026

Description

Pins actions and docker images to specific SHAs to help prevent supply chain attacks.

Related Issue(s)

Should automatically close many of the "Pinned-Dependencies" alerts: https://github.com/vitessio/vitess/security/code-scanning?query=is:open+branch:main+rule:PinnedDependenciesID+

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Help from Claude

@mhamza15 mhamza15 self-assigned this Jan 14, 2026
@github-actions github-actions bot added this to the v24.0.0 milestone Jan 14, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 14, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 14, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.89%. Comparing base (d38ee62) to head (519ccc6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19143      +/-   ##
==========================================
- Coverage   69.90%   69.89%   -0.01%     
==========================================
  Files        1613     1613              
  Lines      216076   216076              
==========================================
- Hits       151055   151034      -21     
- Misses      65021    65042      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pins actions and docker images to specific SHAs to help prevent supply
chain attacks.

Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mhamza15 ! ❤️

@arthurschreiber
Copy link
Member

arthurschreiber commented Jan 14, 2026

Do we need a plan for how to keep the Dockerfile base image versions up to date without causing a lot of churn?

@arthurschreiber
Copy link
Member

We probably should also do something like this on the v22 and v23 branches.

@mhamza15
Copy link
Collaborator Author

Do we need a plan for how to keep the Dockerfile base image versions up to date without causing a lot of churn?

We should be able to use Dependabot! I'll take a look at configuring it if it isn't already

@mhamza15 mhamza15 added Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 15, 2026
@mhamza15 mhamza15 added Type: CI/Build Backport to: release-22.0 Needs to be backport to release-22.0 Backport to: release-23.0 Needs to be backport to release-23.0 labels Jan 15, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@mhamza15 mhamza15 removed Backport to: release-22.0 Needs to be backport to release-22.0 Backport to: release-23.0 Needs to be backport to release-23.0 labels Jan 15, 2026
@mhamza15 mhamza15 enabled auto-merge (squash) January 15, 2026 15:07
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
@mhamza15 mhamza15 added the Type: Dependencies Dependency updates label Jan 15, 2026
@mhamza15 mhamza15 merged commit d5f5e2a into vitessio:main Jan 15, 2026
108 of 110 checks passed
mhamza15 added a commit to mhamza15/vitess that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants