Skip to content

[release-23.0] Fix forward compatibility in upgrade/downgrade tests #18993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arthurschreiber wants to merge 1 commit into from
Closed

[release-23.0] Fix forward compatibility in upgrade/downgrade tests #18993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion go/test/endtoend/preparestmt/stmt_methods_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"vitess.io/vitess/go/test/endtoend/cluster"
"vitess.io/vitess/go/vt/vtgate/engine"
)

Expand Down Expand Up @@ -570,7 +571,17 @@ func validateBaselineErrSpecializedPlan(t *testing.T, p map[string]any) {
pm, ok := plan.(map[string]any)
require.True(t, ok, "plan is not of type map[string]any")
require.EqualValues(t, "PlanSwitcher", pm["OperatorType"])
require.EqualValues(t, "VT12001: unsupported: OVER CLAUSE with sharded keyspace", pm["BaselineErr"])

ver, err := cluster.GetMajorVersion("vtgate")
require.NoError(t, err)

// v24+ uses new error message format
// v23 and earlier uses old format
expectedErr := "VT12001: unsupported: window functions are only supported for single-shard queries"
if ver < 24 {
expectedErr = "VT12001: unsupported: OVER CLAUSE with sharded keyspace"
}
require.EqualValues(t, expectedErr, pm["BaselineErr"].(string))

pd, err := engine.PrimitiveDescriptionFromMap(plan.(map[string]any))
require.NoError(t, err)
Expand Down
Loading