Skip to content

[release-23.0] Fix vtadmin package-lock.json (#18919)#18924

Merged
timvaillancourt merged 1 commit intorelease-23.0from
backport-pr-18919-release-23.0
Nov 20, 2025
Merged

[release-23.0] Fix vtadmin package-lock.json (#18919)#18924
timvaillancourt merged 1 commit intorelease-23.0from
backport-pr-18919-release-23.0

Conversation

@timvaillancourt
Copy link
Copy Markdown
Contributor

@timvaillancourt timvaillancourt commented Nov 20, 2025 •
edited
Loading

Description

Manual backport of #18919 to fix release-23.0, which also has the package-lock.json problem

cc @arthurschreiber

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Nov 20, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 20, 2025
@github-actions github-actions bot added this to the v23.0.1 milestone Nov 20, 2025
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 20, 2025
@timvaillancourt timvaillancourt self-assigned this Nov 20, 2025
@arthurschreiber arthurschreiber added the Backport This is a backport label Nov 20, 2025
@arthurschreiber @timvaillancourt
Fix vtadmin package-lock.json (#18919)
cafcc85 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt force-pushed the backport-pr-18919-release-23.0 branch from 19cafdd to cafcc85 Compare November 20, 2025 15:31
@timvaillancourt timvaillancourt enabled auto-merge (squash) November 20, 2025 15:31
@timvaillancourt timvaillancourt merged commit 1dc965e into release-23.0 Nov 20, 2025
104 checks passed
@timvaillancourt timvaillancourt deleted the backport-pr-18919-release-23.0 branch November 20, 2025 15:35
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (vitessio#18919) (vitess…
8627789 
…io#18924)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (vitessio#18919) (vitess…
bf836b5 
…io#18924)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (vitessio#18919) (vitess…
34e7479 
…io#18924)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (vitessio#18919) (vitess…
c75a6c9 
…io#18924)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurschreiber arthurschreiber arthurschreiber approved these changes

@mattlord mattlord mattlord approved these changes

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 is a code owner

Assignees

@timvaillancourt timvaillancourt

Labels

Backport This is a backport Component: VTAdmin VTadmin interface Type: Bug Type: CI/Build

Projects

None yet

Milestone

v23.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@timvaillancourt @arthurschreiber @mattlord