Skip to content

Fix vtadmin package-lock.json#18919

Merged
timvaillancourt merged 1 commit intomainfrom
arthur/vtadmin-package-lock
Nov 20, 2025
Merged

Fix vtadmin package-lock.json#18919
timvaillancourt merged 1 commit intomainfrom
arthur/vtadmin-package-lock

Conversation

@arthurschreiber
Copy link
Copy Markdown
Member

@arthurschreiber arthurschreiber commented Nov 20, 2025 •
edited
Loading

Description

Seems like this file was not updated correctly, and is now causing failures in unrelated pull requests (e.g #18714 has a failure on the "Static Code Checks" workflow).

Related Issue(s)

I think this issue was introduced by #18908.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@arthurschreiber
Fix vtadmin package-lock.json.
5342232 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Nov 20, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 20, 2025
@github-actions github-actions bot added this to the v24.0.0 milestone Nov 20, 2025
@arthurschreiber arthurschreiber added Type: Bug Component: Build/CI Component: VTAdmin VTadmin interface and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Nov 20, 2025
@timvaillancourt timvaillancourt merged commit 85ba32c into main Nov 20, 2025
112 of 117 checks passed
@timvaillancourt timvaillancourt deleted the arthur/vtadmin-package-lock branch November 20, 2025 14:33
@timvaillancourt timvaillancourt mentioned this pull request Nov 20, 2025
Merged
5 tasks
timvaillancourt pushed a commit that referenced this pull request Nov 20, 2025
@arthurschreiber @timvaillancourt
Fix vtadmin package-lock.json (#18919)
cafcc85 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt added a commit that referenced this pull request Nov 20, 2025
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (#18919) (#18924)
1dc965e 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
siddharth16396 pushed a commit to siddharth16396/postpone-complete that referenced this pull request Dec 3, 2025
@arthurschreiber @siddharth16396
Fix vtadmin package-lock.json (vitessio#18919)
79f4c39 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: siddharth16396 <siddharth16396@gmail.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (vitessio#18919) (vitess…
8627789 
…io#18924)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (vitessio#18919) (vitess…
bf836b5 
…io#18924)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (vitessio#18919) (vitess…
34e7479 
…io#18924)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
jwangace pushed a commit to jwangace/vitess that referenced this pull request Feb 5, 2026
@timvaillancourt @arthurschreiber
[release-23.0] Fix vtadmin package-lock.json (vitessio#18919) (vitess…
c75a6c9 
…io#18924)

Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Jun Wang <jun.wang@demonware.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbussink dbussink dbussink approved these changes

@timvaillancourt timvaillancourt timvaillancourt approved these changes

@beingnoble03 beingnoble03 Awaiting requested review from beingnoble03 beingnoble03 is a code owner

Assignees

No one assigned

Labels

Component: Build/CI Component: VTAdmin VTadmin interface Type: Bug

Projects

None yet

Milestone

v24.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@arthurschreiber @dbussink @timvaillancourt