Skip to content

VReplication: Improve permission check logic on external tablets on SwitchTraffic#18348

Merged
rohit-nayak-ps merged 6 commits into
vitessio:mainfrom
planetscale:rohit/sidecar-creds
Jul 5, 2025
Merged

VReplication: Improve permission check logic on external tablets on SwitchTraffic#18348
rohit-nayak-ps merged 6 commits into
vitessio:mainfrom
planetscale:rohit/sidecar-creds

Remove duplicate defaults in help text

3329073
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 10, 2025 in 0s

67.49% (+0.00%) compared to 2520f7f

View this Pull Request on Codecov

67.49% (+0.00%) compared to 2520f7f

Details

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (2520f7f) to head (3329073).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletmanager/rpc_vreplication.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18348   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files        1603     1603           
  Lines      262428   262448   +20     
=======================================
+ Hits       177114   177139   +25     
+ Misses      85314    85309    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.