Check consultopo loaded >=1 credentials w/-consul_auth_static_file#18152
Merged
timvaillancourt merged 5 commits intovitessio:mainfrom Jun 5, 2025
Merged
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
consultopo loaded >0 credentialsconsultopo loaded >=1 credentials w/-consul_auth_static_file
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18152 +/- ##
=======================================
Coverage 67.48% 67.48%
=======================================
Files 1603 1603
Lines 262337 262388 +51
=======================================
+ Hits 177034 177081 +47
- Misses 85303 85307 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
consultopo loaded >=1 credentials w/-consul_auth_static_fileconsultopo loaded >=1 credentials w/-consul_auth_static_file
5 tasks
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Apr 17, 2025
* Check `consultopo` loaded >0 credentials Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test, again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * force CI to run again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
5 tasks
Contributor
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
deepthi
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR confirms
consultopoloaded >= 1 credential(s) when using-consul_auth_static_fileThis is to address no validation errors when a valid-but-empty JSON config is provided, ie:
{}Related Issue(s)
Related to: #18150
Checklist
Deployment Notes