slack 19.0: pre backport vitessio/vitess#18152#638
Merged
timvaillancourt merged 6 commits intoslack-19.0from Apr 17, 2025
Merged
slack 19.0: pre backport vitessio/vitess#18152#638timvaillancourt merged 6 commits intoslack-19.0from
slack 19.0: pre backport vitessio/vitess#18152#638timvaillancourt merged 6 commits intoslack-19.0from
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
slack 19.0: pre backport vitessio/vitess#18152
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
ejortegau
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is an early backport of v23 PR: vitessio#18152
This PR checks that consul static credentials were actually loaded, to address a problem we saw when the consul token is valid but empty, eg:
{}Related Issue(s)
Checklist
Deployment Notes