Skip to content

slack 19.0: pre backport vitessio/vitess#18152#638

Merged
timvaillancourt merged 6 commits intoslack-19.0from
bp-pr18152.slack-19.0
Apr 17, 2025
Merged

slack 19.0: pre backport vitessio/vitess#18152#638
timvaillancourt merged 6 commits intoslack-19.0from
bp-pr18152.slack-19.0

Conversation

@timvaillancourt
Copy link

Description

This PR is an early backport of v23 PR: vitessio#18152

This PR checks that consul static credentials were actually loaded, to address a problem we saw when the consul token is valid but empty, eg: {}

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt requested a review from a team as a code owner April 10, 2025 21:14
@timvaillancourt timvaillancourt changed the title Bp pr18152.slack 19.0 slack 19.0: pre backport vitessio/vitess#18152 Apr 10, 2025
@github-actions github-actions bot added this to the v19.0.7 milestone Apr 10, 2025
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt merged commit 6d817c5 into slack-19.0 Apr 17, 2025
161 of 167 checks passed
@timvaillancourt timvaillancourt deleted the bp-pr18152.slack-19.0 branch April 17, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants