vtorc: add stats for discovery workers#17937
Merged
timvaillancourt merged 1 commit intovitessio:mainfrom Mar 17, 2025
Merged
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17937 +/- ##
==========================================
- Coverage 67.56% 67.55% -0.02%
==========================================
Files 1597 1597
Lines 259780 259787 +7
==========================================
- Hits 175516 175488 -28
- Misses 84264 84299 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
93e34ea to
1f5cbac
Compare
5 tasks
GuptaManan100
approved these changes
Mar 16, 2025
deepthi
approved these changes
Mar 17, 2025
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Mar 17, 2025
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
5 tasks
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Mar 17, 2025
* `vtorc`: remove duplicate instance read from backend (vitessio#17834) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * `vtorc`: add index for `inst.ReadInstanceClusterAttributes` table scan (vitessio#17866) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add stats for shards watched by VTOrc, purge stale shards (vitessio#17815) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove unused code in discovery queue creation (vitessio#17515) Signed-off-by: Manan Gupta <manan@planetscale.com> * `vtorc`: cleanup discover queue, add concurrency flag (vitessio#17825) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make compat with v21 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * `vtorc`: use `errgroup` in keyspace/shard discovery (vitessio#17857) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * missing `sync` import Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * `vtorc`: skip unnecessary backend read in `logic.LockShard(...)` (vitessio#17900) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * `vtorc`: add tablets watched stats (vitessio#17911) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * `vtorc`: add stats for discovery workers (vitessio#17937) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two gauges to VTOrc:
DiscoveryWorkers/vtorc_discovery_workers- the number of discovery worker goroutinesDiscoveryWorkersActive/vtorc_discovery_workers_active- the number of discovery worker goroutines currently doing workThis will be useful for tuning discovery worker/queue concurrency
Related Issue(s)
#17330
Checklist
Deployment Notes