Skip to content

slack 21.0: backport v22 VTOrc improvements, part 2#622

Merged
timvaillancourt merged 11 commits intoslack-21.0from
bp-v22-vtorc-opts-pt2.slack-21.0
Mar 17, 2025
Merged

slack 21.0: backport v22 VTOrc improvements, part 2#622
timvaillancourt merged 11 commits intoslack-21.0from
bp-v22-vtorc-opts-pt2.slack-21.0

Conversation

@timvaillancourt
Copy link

@timvaillancourt timvaillancourt commented Mar 12, 2025

Description

This PR backports more v22 VTOrc fixes we run on slack-19.0:

  1. vtorc: remove duplicate instance read from backend vitessio/vitess#17834
  2. vtorc: add index for inst.ReadInstanceClusterAttributes table scan vitessio/vitess#17866
  3. Add stats for shards watched by VTOrc, purge stale shards vitessio/vitess#17815
  4. Remove unused code in discovery queue creation vitessio/vitess#17515
  5. vtorc: cleanup discover queue, add concurrency flag vitessio/vitess#17825
  6. vtorc: use errgroup in keyspace/shard discovery vitessio/vitess#17857
  7. vtorc: skip unnecessary backend read in logic.LockShard(...) vitessio/vitess#17900
  8. vtorc: add tablets watched stats vitessio/vitess#17911
  9. vtorc: add stats for discovery workers vitessio/vitess#17937

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

timvaillancourt and others added 5 commits March 12, 2025 14:06
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
vitessio#17866)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
…7815)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v21.0.3 milestone Mar 12, 2025
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt marked this pull request as ready for review March 12, 2025 14:22
@timvaillancourt timvaillancourt requested a review from a team as a code owner March 12, 2025 14:22
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
…essio#17900)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt merged commit bf49471 into slack-21.0 Mar 17, 2025
184 of 185 checks passed
@timvaillancourt timvaillancourt deleted the bp-v22-vtorc-opts-pt2.slack-21.0 branch March 17, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants